Skip to content
This repository has been archived by the owner on Sep 20, 2024. It is now read-only.

webex adapter: dialog in thread does not work with "ask" #2195

Closed
monzonj opened this issue Feb 6, 2022 · 2 comments
Closed

webex adapter: dialog in thread does not work with "ask" #2195

monzonj opened this issue Feb 6, 2022 · 2 comments
Assignees

Comments

@monzonj
Copy link
Contributor

monzonj commented Feb 6, 2022

In webex, it is possible to start conversations in threads. For the most part, it works fine with startConversationInThread however commands such as ask or addQuestion do not capture the answers

For instance, this case:

    const MY_DIALOG_ID = 'my-dialog-name-constant';
    const convo = new BotkitConversation(MY_DIALOG_ID, controller);
    convo.ask('What is your name?', async(response, convo, bot) => {
        console.log(`user name is ${ response }`);
    }, 'name');
    controller.addDialog(convo);

    controller.hears('yo', 'message', async(bot, message) => {
        await bot.startConversationInThread(message.channel, message.user, message.id);
        await bot.beginDialog(MY_DIALOG_ID);
    });

The conversation should go like this (imagine that the bot name is "mybot")

me: @mybot yo
         (threat starts)
         mybot: What is your name?
         me: @mybot Joe
         (conversation ends. NOTHING is logged in the console)

However, if I omit the startConversationInThread all works as expected (just not in a threat)

  • Botkit version: 4.10.0
  • Messaging Platform: WEBEX ( botbuilder-adapter-webex": "^1.0.9" )
  • Node version: v17.4.0
  • Os: MacOS
@monzonj
Copy link
Contributor Author

monzonj commented Feb 13, 2022

I've created a PR with the fix: #2198

@benbrown benbrown self-assigned this Mar 23, 2022
@benbrown
Copy link
Contributor

PR merged and published.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants