Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Spatial Pooler Parameter Structure #332

Closed
ctrl-z-9000-times opened this issue Mar 18, 2019 · 3 comments
Closed

Spatial Pooler Parameter Structure #332

ctrl-z-9000-times opened this issue Mar 18, 2019 · 3 comments
Labels
code code enhancement, optimization, cleanup..programmer stuff feature new feature, extending API help wanted Extra attention is needed newbie SP

Comments

@ctrl-z-9000-times
Copy link
Collaborator

The Spatial Pooler has too many parameters. It would be much easier to work with the spatial pooler if it used a structure to hold its parameters.

For a good example of parameter structures in action, look at the files:

src/nupic/encoders/ScalarEncoder.hpp
src/nupic/encoders/ScalarEncoder.cpp

If someone wants to work on this I will be happy to help.

@ctrl-z-9000-times ctrl-z-9000-times added help wanted Extra attention is needed newbie SP feature new feature, extending API code code enhancement, optimization, cleanup..programmer stuff labels Mar 18, 2019
@ctrl-z-9000-times
Copy link
Collaborator Author

Related PR #279, #5, #209
Would help with issues: #92, #316, #86

@ctrl-z-9000-times ctrl-z-9000-times added this to the Release version 1.0 milestone Mar 21, 2019
@breznak
Copy link
Member

breznak commented Mar 21, 2019

I would like to see this as a requirement in #295 (albeit the "Computable" is hard to describe generally enough)

@ctrl-z-9000-times
Copy link
Collaborator Author

I'd like to close this issue as WON'T FIX.

  • Changing this would break all of the existing SPs. It's not as simple to fix this without breaking compatibility.
  • The current way of using the SP works. New features can be added to the SP with setter/getter methods.
  • There are easier ways to improve the usability of this library. My guesstimate of added value per hour of work for this issue is too low.
  • In the future, algorithms with many parameters should definitely use a parameter structure.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
code code enhancement, optimization, cleanup..programmer stuff feature new feature, extending API help wanted Extra attention is needed newbie SP
Projects
None yet
Development

No branches or pull requests

2 participants