Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update void elements #203

Closed
annevk opened this issue Aug 17, 2015 · 2 comments · Fixed by #563
Closed

Update void elements #203

annevk opened this issue Aug 17, 2015 · 2 comments · Fixed by #563

Comments

@annevk
Copy link
Contributor

annevk commented Aug 17, 2015

https://github.com/html5lib/html5lib-python/blob/master/html5lib/constants.py#L487 is no longer accurate. Seems to miss keygen, wbr, menuitem.

And seems to have event-source which is no longer a thing.
@twm twm mentioned this issue Jul 5, 2020
Merged
@g-k g-k mentioned this issue Sep 16, 2020
Open
@jayaddison
Copy link
Contributor

@willkg @gsnedders fyi - it looks like #395 can contribute to resolving this issue.

NB: The code block referenced in the issue description within constants.py is now viewable here.

@ambv ambv mentioned this issue Mar 2, 2023
Merged
@ambv
Copy link
Member

ambv commented Mar 2, 2023

Looks like menuitem is deprecated, and moreover not really void.

keygen is also deprecated.

So the only missing one is wbr.

I don't think it's worth adding keygen as it's already deprecated and was never used in html5lib. Moreover, I think we could rather uncontroversially remove command (removed entirely from the spec in 2012), and event-source (renamed to eventsource in July 2008 and dropped entirely in February 2009).

@ambv ambv mentioned this issue Mar 2, 2023
Merged
@ambv ambv closed this as completed in #563 Mar 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ambv @annevk @jayaddison