Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add promise variant of getSocket method #169

Open
MasterOdin opened this issue Mar 12, 2025 · 1 comment · May be fixed by #179
Open

Add promise variant of getSocket method #169

MasterOdin opened this issue Mar 12, 2025 · 1 comment · May be fixed by #179

Comments

@MasterOdin
Copy link
Contributor

There's a promise variant of getPort and getPorts, there should then also be a promise variant of getSocket as well.

@eriktrom If this gets done, would you want to see both a getSocketPromise method as well as having getSocket be able to return a promise (assuming #168 is merged as that lays out the implementation pattern).
@eriktrom eriktrom mentioned this issue Mar 12, 2025
Merged
@eriktrom
Copy link
Member

eriktrom commented Mar 12, 2025 •
edited
Loading

Yes, and Yes

Yes lets add a getSocketPromise and lets alias it to getSocket using the same idea from #168

@eriktrom eriktrom mentioned this issue Mar 12, 2025
Open
@MasterOdin MasterOdin linked a pull request Mar 15, 2025 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add promise return for getSocket MasterOdin/node-portfinder
2 participants
@eriktrom @MasterOdin