Skip to content

The IsahcClient timeout setting is not a connection timeout #103

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
trrk opened this issue Apr 10, 2022 · 1 comment · May be fixed by #107
Open

The IsahcClient timeout setting is not a connection timeout #103

trrk opened this issue Apr 10, 2022 · 1 comment · May be fixed by #107
Labels
bug Something isn't working

Comments

@trrk
Copy link

trrk commented Apr 10, 2022

I believe the timeout that can be set through http_client refers to the connection timeout. And I think the process shown below sets a timeout on isahc. According to the isahc documentation, it is not the connection timeout that can be set with timeout(). The connection timeout can be set with connect_timeout().

http-client/src/isahc.rs

Line 90 in 3c0ed9a

builder = builder.timeout(timeout);

http-client/src/isahc.rs

Line 118 in 3c0ed9a

builder = builder.timeout(timeout);

@Fishrock123
Copy link
Member

@trrk will accept a PR if you make one. :)

@Fishrock123 Fishrock123 added the bug Something isn't working label May 10, 2022
@trrk trrk linked a pull request Aug 7, 2022 that will close this issue
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong kind of timeout set to isahc trrk/http-client
2 participants
@Fishrock123 @trrk