-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
auto-merge functionality #2
Comments
Some useful resources here: https://github.com/pascalgn/automerge-action The above action uses label to decide what to automerge. We could make the validation workflow create an automerge label on the PR. If validation succeeds, it could then trigger the automerge workflow. Depending on how exactly we implement this, it could be set via hub config or it could be a whole separate GitHub Action that needs to be explicitly added to a hub that is either linked to the validations workflow or just monitors for the automerge label which the validations workflow creates. It would be good to spell out when exactly this will be activated. for example, if a PR contains changes to files not validated, should auto-merge still be performed if validations pass? |
Useful resources supplied by @sbidari related to a sandbox hub where the functionality has been implemented |
See also related issue hubverse-org/hubValidations#9 about having auto-merge functionality apply to authorised submittersonly which is also implemented globally in the above example. Ideally we'd want each model_id directory to only be editable by the team members specified in the a model metadata property. |
There should be an optional setting at the hub level for whether to auto-merge PRs upon successful validation.
The text was updated successfully, but these errors were encountered: