Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add timeout parameter to HfApi.dataset_info to work on JZ #372

Closed
lhoestq opened this issue Sep 28, 2021 · 0 comments · Fixed by #373
Closed

Add timeout parameter to HfApi.dataset_info to work on JZ #372

lhoestq opened this issue Sep 28, 2021 · 0 comments · Fixed by #373
Labels
enhancement New feature or request

Comments

@lhoestq
Copy link
Member

lhoestq commented Sep 28, 2021

In certain environments such as the Jean Zay cluster, there is no internet connection and internet requests hang indefinitely.

To be able to properly raise an error in such cases instead of making the program hang, I think it would be nice to add a timeout parameter to HfApi.dataset_info that can be passed to requests.get.

The datasets CI has a test where it simulates such an environment. So when I try to use HfApi.dataset_info in datasets, it makes the CI fail.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant