From fe855e7ed660c4ddce6fe4a618e94b4efe89819e Mon Sep 17 00:00:00 2001 From: Shantanu <12621235+hauntsaninja@users.noreply.github.com> Date: Fri, 12 Aug 2022 19:28:47 -0700 Subject: [PATCH] Use --no-implicit-optional for type checking (#3220) This makes type checking PEP 484 compliant (as of 2018). mypy will change its defaults soon. See: https://github.com/python/mypy/issues/9091 https://github.com/python/mypy/pull/13401 --- mypy.ini | 1 + src/blib2to3/pgen2/parse.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/mypy.ini b/mypy.ini index 8ee9068d10b..244e8ae92f5 100644 --- a/mypy.ini +++ b/mypy.ini @@ -22,6 +22,7 @@ warn_no_return=True warn_redundant_casts=True warn_unused_ignores=True disallow_any_generics=True +no_implicit_optional=True # Unreachable blocks have been an issue when compiling mypyc, let's try # to avoid 'em in the first place. diff --git a/src/blib2to3/pgen2/parse.py b/src/blib2to3/pgen2/parse.py index a9dc11f39ce..d6deaac6964 100644 --- a/src/blib2to3/pgen2/parse.py +++ b/src/blib2to3/pgen2/parse.py @@ -114,7 +114,7 @@ def add_token(self, tok_type: int, tok_val: Text, raw: bool = False) -> None: args.insert(0, ilabel) func(*args) - def determine_route(self, value: Text = None, force: bool = False) -> Optional[int]: + def determine_route(self, value: Optional[Text] = None, force: bool = False) -> Optional[int]: alive_ilabels = self.ilabels if len(alive_ilabels) == 0: *_, most_successful_ilabel = self._dead_ilabels