Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

finished CTFs still showing under Import #15

Closed
lanjelot opened this issue Dec 20, 2020 · 3 comments
Closed

finished CTFs still showing under Import #15

lanjelot opened this issue Dec 20, 2020 · 3 comments

Comments

@lanjelot
Copy link
Collaborator

lanjelot commented Dec 20, 2020

Is this because @lru_cache makes ctftime_fetch_running_ctf_data() return old events at https://github.com/hugsy/ctfpad/blob/master/ctfpad/views/ctfs.py#L33?

@hugsy
Copy link
Owner

hugsy commented Dec 20, 2020

Likely.

But we need some caching here, fetching data from ctftime is a too long operation not to be cached.

@lanjelot
Copy link
Collaborator Author

lanjelot commented Dec 21, 2020

Can we lower the TTL at all? Or rather what we should do is filter out ctfs that have ended. I'll look into it.

@hugsy
Copy link
Owner

hugsy commented Dec 21, 2020

You can flush the cache but then there's no point.

We can always hide (or add a notation to) the CTF already finished.

@hugsy hugsy closed this as completed in b7c34f6 Dec 22, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants