Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reconsider use of eslint-config-react-app #252

Open
pdewouters opened this issue Mar 31, 2021 · 1 comment
Open

Reconsider use of eslint-config-react-app #252

pdewouters opened this issue Mar 31, 2021 · 1 comment
Labels

Comments

@pdewouters
Copy link
Contributor

The react-app config doesn't seem to be updated that often and is probably very opinionated towards apps created with create-react-app

I think it makes sense to take a more generic approach and instead we could use plugin:react/recommended as a base.

Alternatively, we should probably be using https://developer.wordpress.org/block-editor/reference-guides/packages/packages-eslint-plugin/

which is the one used by Gutenberg.

@tfrommen tfrommen added the eslint label Apr 6, 2021
@svandragt
Copy link
Contributor

svandragt commented Apr 7, 2021

 ├─┬ @wordpress/scripts@7.2.0
   └─┬ @wordpress/eslint-plugin@4.1.0
     └── babel-eslint@10.1.0

vs

npm WARN eslint-config-react-app@3.0.8 requires a peer of babel-eslint@9.x but none is installed. You must install peer dependencies yourself.

Using this package in combination with @wordpress/scripts results in an incompatibility.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants