Convert images to SVG #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This process used Inkscape's bitmap tracing, roughly halving total image file size :) Signed-off-by: microlith57 <microlith57@gmail.com>
|
It might also be good to move all the assets into one location so they can be used by both |
- SVGs change colour with theme changes (`f_high`) - Fixed issue with `learn` and `help` SVGs having weird outline when themed Signed-off-by: microlith57 <microlith57@gmail.com>
|
@neauoire Added theming :) Just need to test bundle compatibility. |
|
Oh no; it doesn't work on mac when bundled! Edit: I can use |
Hopefully! Signed-off-by: microlith57 <microlith57@gmail.com>
Signed-off-by: microlith57 <microlith57@gmail.com>
|
@neauoire Ready for review! :) |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34 by converting all images to SVG using line tracing.
Progress:
.svg<img>basis (so that non-changing images can be used in parallel)Note: This PR also adds some documentation in the action code to make it more accessible to new developers :)