Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

i2c(PCA9685, adafruit): clean up architecture and fix init #1021

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Oct 28, 2023

Solved issues and/or description of the change

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s): Tinkerboard & adeept motor HAT 2.0

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

If this is a new driver or adaptor:

  • I have added the name to the corresponding README.md
  • I have added an example to see how to setup and use it
  • I have checked or build at least my new example (e.g. by run make examples_check)

@gen2thomas gen2thomas force-pushed the fix/linter_noinits branch 5 times, most recently from 95e0e7a to fe38072 Compare October 29, 2023 16:52
@gen2thomas gen2thomas marked this pull request as ready for review October 29, 2023 18:35
@gen2thomas gen2thomas merged commit 693cbf1 into hybridgroup:dev Oct 29, 2023
@gen2thomas gen2thomas deleted the fix/linter_noinits branch October 29, 2023 18:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant