Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

gpio: fix data race in ButtonDriver #1027

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Nov 1, 2023

Solved issues and/or description of the change

data race in ButtonDriver and MakeyButtonDriver found by go test -race - fixed by rework of ButtonDriver and its tests

the MakeyButtonDriver was removed, because equal implementation

this partially fix #1017

Manual test

none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review November 1, 2023 13:50
@gen2thomas gen2thomas merged commit c41604f into hybridgroup:dev Nov 1, 2023
5 checks passed
@gen2thomas gen2thomas deleted the fix/gpio_datarace_button branch November 1, 2023 13:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant