Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

gpio(all): introduce functional options #1045

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Dec 2, 2023

Solved issues and/or description of the change

#998

additionally:

  • fix flaky tests for AnalogSensorDriver
  • fix ServoWrite() for SG90, AD002
  • improve gpio tests
  • mark various grove drivers as deprecated
  • introduce a migration guide to new version (breaking change)

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s):
    • tinkerboard
      • hd44780
      • servo (pwm, see new example)
      • motor (pwm, see new example)
      • button
    • raspi
      • stepper
      • HCSR04
    • nanopi
      • button

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes (e.g. by run make test)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

If this is a new driver or adaptor:

  • I have added an example to see how to setup and use it
  • I have checked or build at least my new example (e.g. by run make examples_check)

@gen2thomas gen2thomas force-pushed the feature/gpio_variadic branch 8 times, most recently from ea0665b to 2c54001 Compare December 3, 2023 10:15
@gen2thomas gen2thomas force-pushed the feature/gpio_variadic branch from 2c54001 to 6c52b01 Compare December 3, 2023 16:54
@gen2thomas gen2thomas marked this pull request as ready for review December 3, 2023 17:02
@gen2thomas gen2thomas merged commit be1ccf0 into hybridgroup:dev Dec 3, 2023
@gen2thomas gen2thomas deleted the feature/gpio_variadic branch December 3, 2023 17:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant