Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tests: fix for arm64 environment and stabilize #1115

Merged
merged 1 commit into from
Jan 4, 2025
Merged

tests: fix for arm64 environment and stabilize #1115

merged 1 commit into from
Jan 4, 2025

Conversation

gen2thomas
Copy link
Collaborator

@gen2thomas gen2thomas commented Jan 4, 2025 •
edited
Loading

Solved issues and/or description of the change

Some unit tests with float numbers fail when running in arm64 environment. Some event based unit tests are known to be flaky. This PR covers both problems.

Manual test

  • OS and Version (Win/Mac/Linux): Linux
  • Adaptor(s) and/or driver(s): none

Checklist

  • The PR's target branch is 'hybridgroup:dev'
  • New and existing unit tests pass locally with my changes (e.g. by run make test_race)
  • No linter errors exist locally (e.g. by run make fmt_check)
  • I have performed a self-review of my own code

@gen2thomas gen2thomas marked this pull request as ready for review January 4, 2025 10:54
@gen2thomas gen2thomas merged commit 302614e into hybridgroup:dev Jan 4, 2025
3 checks passed
@gen2thomas gen2thomas deleted the fix/stabilize_unit_tests branch January 4, 2025 10:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gen2thomas