Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Mavlink: common.go & mavlink.go contains many lines without error check #949

Closed
gen2thomas opened this issue Jun 11, 2023 · 0 comments
Closed

Mavlink: common.go & mavlink.go contains many lines without error check #949

gen2thomas opened this issue Jun 11, 2023 · 0 comments
Labels
enhancement

Comments

@gen2thomas
Copy link
Collaborator

Linter "errcheck" found issues, in common.go but there are to many lines to fix it immediately. Errors are currently suppressed by "nolint" directive on file level, but IMO it would be useful to check all the "binary.Write" and "binary.Read" lines to prevent unexpected data.
@gen2thomas gen2thomas changed the title Mavlink: common.go contains many lines with error check Mavlink: common.go & mavlink.go contains many lines with error check Jun 11, 2023
@gen2thomas gen2thomas changed the title Mavlink: common.go & mavlink.go contains many lines with error check Mavlink: common.go & mavlink.go contains many lines without error check Jun 14, 2023
@gen2thomas gen2thomas mentioned this issue Jun 14, 2023
Merged
4 tasks
@gen2thomas gen2thomas added the done on dev the feature or bug is solved on dev branch and wait for merge to release branch label Jun 14, 2023
@gen2thomas gen2thomas removed the done on dev the feature or bug is solved on dev branch and wait for merge to release branch label Oct 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gen2thomas