fix(define): remove element class bridge thanks to babel v7

hybridsjs · Oct 4, 2018 · c0d6c9a · c0d6c9a
1 parent fccb3f8
commit c0d6c9a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 12 deletions.
diff --git a/shim.js b/shim.js
@@ -3,7 +3,6 @@
 // Web APIs polyfills for IE11
 if ('ActiveXObject' in window) {
   require('core-js/fn/array/find');
-  require('core-js/fn/reflect/construct');
   require('core-js/es6/promise');
 }
 

diff --git a/src/define.js b/src/define.js
@@ -84,12 +84,6 @@ if (process.env.NODE_ENV !== 'production') {
   };
 }
 
-// BUG: Babel v6 transpiled class breaks native custom elements
-export function HTMLBridge(...args) {
-  return Reflect.construct(HTMLElement, args, this.constructor);
-}
-Object.setPrototypeOf(HTMLBridge.prototype, HTMLElement.prototype);
-
 const connects = new WeakMap();
 
 function defineElement(tagName, hybridsOrConstructor) {
@@ -127,7 +121,7 @@ function defineElement(tagName, hybridsOrConstructor) {
     throw Error(`[define] Element '${tagName}' already defined`);
   }
 
-  class Hybrid extends HTMLBridge {
+  class Hybrid extends HTMLElement {
     static get name() { return tagName; }
 
     connectedCallback() {

diff --git a/test/spec/define.js b/test/spec/define.js
@@ -1,5 +1,5 @@
 import { test } from '../helpers';
-import define, { HTMLBridge } from '../../src/define';
+import define from '../../src/define';
 import { invalidate } from '../../src/cache';
 
 describe('define:', () => {
@@ -23,7 +23,7 @@ describe('define:', () => {
     });
 
     it('defines custom elements constructor', () => {
-      class TestHtmlDefineExternalA extends HTMLBridge {
+      class TestHtmlDefineExternalA extends HTMLElement {
         constructor() {
           super();
           this.value = 'test';

diff --git a/test/spec/html.js b/test/spec/html.js
@@ -1,6 +1,6 @@
 import { html } from '../../src/html';
 import { createInternalWalker } from '../../src/html/template';
-import define, { HTMLBridge } from '../../src/define';
+import define from '../../src/define';
 
 describe('html:', () => {
   let fragment;
@@ -552,7 +552,7 @@ describe('html:', () => {
   });
 
   describe('use external element with shadowRoot', () => {
-    class TestExternalElement extends HTMLBridge {
+    class TestExternalElement extends HTMLElement {
       constructor() {
         super();
         const shadowRoot = this.attachShadow({ mode: 'open' });