Skip to content
This repository has been archived by the owner on Dec 26, 2024. It is now read-only.

Useless switch statement #52

Closed
yujonglee opened this issue Aug 8, 2021 · 2 comments · Fixed by #53
Closed

Useless switch statement #52

yujonglee opened this issue Aug 8, 2021 · 2 comments · Fixed by #53
Labels
🍗 enhancement New feature or request

Comments

@yujonglee
Copy link
Contributor

yujonglee commented Aug 8, 2021 •
edited
Loading

https://github.com/dooboolab/dooboo-ui/blob/d9721babfd7a6d8a20172bdef3e775d617c2cb8c/docs/src/components/ButtonGroup/index.tsx#L32-L40

https://github.com/dooboolab/dooboo-ui/blob/d9721babfd7a6d8a20172bdef3e775d617c2cb8c/stories/dooboo-ui/ButtonGroupStories/index.tsx#L33-L41

I think switch statement is uselsss here. Am I missing something?
@hyochan hyochan added the 🍗 enhancement New feature or request label Aug 8, 2021
@hyochan
Copy link
Owner

hyochan commented Aug 8, 2021

@yujong-lee Nope you've exactly caught the redundancy. Looks like we can remove that. Moreover, the examples for [ButtonGroup] are currently in naive status. Mostly because they are minimally delivered from our legacy project.

What I am looking for

When providing some advanced samples for each component, we might be able to look into some limitations and we can improve our component more flexibly.

@yujonglee yujonglee mentioned this issue Aug 8, 2021
Merged
4 tasks
@hyochan hyochan linked a pull request Aug 8, 2021 that will close this issue
Rewrite [ButtonGroup] test #53
Merged
4 tasks
@yujonglee
Copy link
Contributor Author

Resolved by #56. [This] is moved to new issue.

@yujonglee yujonglee mentioned this issue Aug 9, 2021
Closed
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
🍗 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite [ButtonGroup] test
2 participants
@hyochan @yujonglee