Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Calva user reports regression in reporter formatting related to newlines #66

Open
dustingetz opened this issue Sep 6, 2022 · 2 comments

Comments

@dustingetz
Copy link
Member

Daniel Jomphe
Here's a screenshot taken in May with Calva.
Lines 942 and 969...
It made REPL printing much faster - one line per success slows down things a lot in Calva.

image

2m
Daniel Jomphe
I tested the latest RCF releases with Calva.
20220405 (and earlier) prints them all on the same line
20220827-151056 prints each ✅ on a newline
20220902-130636 prints each ✅ on a newline

@dustingetz dustingetz changed the title Calva user reports newline issue in reporter formatting Calva user reports regression in reporter formatting related to newlines Sep 6, 2022
@dustingetz
Copy link
Member Author

Reporters.cljs before April 5:

(do (js/console.groupCollapsed "" (testing-vars-str m))

First change after April 5:
(js/console.log ""))

@ggeoffrey
Copy link
Member

I initially replied to Daniel that RCF always printed one per line in Calva. I was wrong.

The attached screenshot shows a CLJ REPL. We should look for a difference in reporters.clj, not .cljs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants