From 8b9cabe9b74210a30707a8e90be33520a2bbfe7f Mon Sep 17 00:00:00 2001 From: tottoto Date: Wed, 6 Mar 2024 22:12:43 +0900 Subject: [PATCH 1/3] refactor(ci): remove unused environment variable --- .github/workflows/ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e401d2ab..8eb6ff09 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,9 +2,6 @@ name: CI on: [push, pull_request] -env: - minrust: 1.56.0 - jobs: test: name: Test From d9ae29a8598eec3fada093a4eca6756ce5731722 Mon Sep 17 00:00:00 2001 From: tottoto Date: Wed, 6 Mar 2024 22:13:17 +0900 Subject: [PATCH 2/3] refactor(ci): run rustfmt on stable rust --- .github/workflows/ci.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8eb6ff09..2114e8d9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -3,6 +3,15 @@ name: CI on: [push, pull_request] jobs: + style: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: dtolnay/rust-toolchain@stable + with: + components: rustfmt + - run: cargo fmt --all --check + test: name: Test runs-on: ubuntu-latest @@ -26,7 +35,6 @@ jobs: cargo clean cargo update -Z minimal-versions cargo check - - run: cargo fmt --all --check MSRV: runs-on: ubuntu-latest From 90b5d3a9546c534c678210e4b744f3cc89859f0f Mon Sep 17 00:00:00 2001 From: tottoto Date: Wed, 6 Mar 2024 22:14:03 +0900 Subject: [PATCH 3/3] refactor(ci): use cargo-minimal-versions to check minimal versions --- .github/workflows/ci.yml | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2114e8d9..43b73b87 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -29,12 +29,16 @@ jobs: - run: cargo test --workspace - if: matrix.rust == 'nightly' run: cargo test --benches - - name: Check minimal versions - if: matrix.rust == 'nightly' - run: | - cargo clean - cargo update -Z minimal-versions - cargo check + + minimal-versions: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: dtolnay/rust-toolchain@nightly + - uses: dtolnay/rust-toolchain@stable + - uses: taiki-e/install-action@cargo-hack + - uses: taiki-e/install-action@cargo-minimal-versions + - run: cargo minimal-versions check --workspace MSRV: runs-on: ubuntu-latest