fix(build): Server service uses generic body bound #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hyperium#281 Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
LucioFranco
requested changes
Mar 28, 2020
tonic-build/src/server.rs
Outdated
| @@ -49,7 +49,7 @@ pub fn generate<'a, T: Service<'a>>(service: &'a T, context: &T::Context) -> Tok | |||
| } | |||
| } | |||
|
|
|||
| impl<T: #server_trait> Service<http::Request<HyperBody>> for #server_service<T> { | |||
| impl<T: #server_trait> Service<http::Request<RequestBody>> for #server_service<T> { | |||
There was a problem hiding this comment.
So instead of making this accept a BoxBody we actually want to make this generic over it. So we can do something like:
impl<T, B> Service<http::Request<B>> for #server_service<T>
where
T: #server_trait,
B: HttpBody + Send + Sync + 'static,
B::Error: Into<StdError> + Send + 'static,
{ ... }There was a problem hiding this comment.
Updated ! Thanks a lot for your help
…hyperium#281 Signed-off-by: Benjamin Coenen <5719034+bnjjj@users.noreply.github.com>
LucioFranco
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
close #281
Solution
I choose to use
BoxBodyas a generic body when the transport feature is disabled. Let me know if it's a good choice.