-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(codec): Enforce encoders/decoders are Sync
#84
Conversation
Yeah...this will be a bit harder than anticipated... |
Yeah, this is the other option. I guess you're in the best position to know which bounds you will be able to satisfy in tonic. For this implementation route we'd also want to add a test that ensures You might also want to add a |
@seanmonstar would you be able to take a look at this? |
What I'm about to say sounds dumb: for trait objects, the order of additional auto traits matters, and most places write them as |
@seanmonstar all i can say is lol |
Does this put #82 back on the table? |
@NeoLegends we still want to go with this one but need to change the order of the bounds. |
@seanmonstar can I get your +1 on this before we merge? |
cc @NeoLegends
Closes #81