Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG] Sumeragi panics with "index out of bounds" message after unregistering a peer #5104

Closed
0x009922 opened this issue Sep 26, 2024 · 0 comments · Fixed by #5157
Closed
Assignees
Labels
Bug Something isn't working

Comments

@0x009922
Copy link
Contributor

OS and Environment

macOs 14.16.1

GIT commit hash

3e86d7b (in #5087)

Minimum working example / Steps to reproduce

Occured while re-implementing test network #5087, test connected_peers.rs integration test suite

  1. Create network with 7 peers, start, wait for genesis
  2. Unregister a random one

Actual result

Sometimes one of the remaining peers may panic:

thread 'sumeragi' panicked at crates/iroha_core/src/sumeragi/main_loop.rs:626:38:
index out of bounds: the len is 6 but the index is 6

At this index access:

https://github.com/hyperledger/iroha/blob/7144f4e83d405bda553a99d7177c5a189452221e/crates/iroha_core/src/sumeragi/main_loop.rs#L626

Expected result

Expected to not panic at any time.

Logs

https://pastebin.com/LXtRDLNe

Who can help to reproduce?

@0x009922

Notes

Used release target of Iroha.

@0x009922 0x009922 added the Bug Something isn't working label Sep 26, 2024
@mversic mversic moved this to High Priority in Iroha Sep 26, 2024
@SamHSmith SamHSmith self-assigned this Sep 30, 2024
@0x009922 0x009922 linked a pull request Oct 18, 2024 that will close this issue
4 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants