Skip to content

Commit 66e0aba

Browse files
committed
Add build image arg
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
1 parent cdb5d12 commit 66e0aba

File tree

5 files changed

+6
-2
lines changed

5 files changed

+6
-2
lines changed

.github/workflows/docker_main.yml

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ jobs:
2525
--label build_date=$(date -u +"%Y-%m-%dT%H:%M:%SZ") \
2626
--label tag=${{ steps.build_tag_generator.outputs.BUILD_TAG }} \
2727
--build-arg BASE_IMAGE=alpine:3.19 \
28+
--build-arg BUILD_IMAGE=golang:1.21-alpine3.19 \
2829
--tag ghcr.io/hyperledger/firefly-fabconnect:${{ steps.build_tag_generator.outputs.BUILD_TAG }} .
2930
3031
- name: Tag release

.github/workflows/docker_release.yml

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ jobs:
1717
--label build_date=$(date -u +"%Y-%m-%dT%H:%M:%SZ") \
1818
--label tag=${GITHUB_REF##*/} \
1919
--build-arg BASE_IMAGE=alpine:3.19 \
20+
--build-arg BUILD_IMAGE=golang:1.21-alpine3.19 \
2021
--tag ghcr.io/hyperledger/firefly-fabconnect:${GITHUB_REF##*/} \
2122
--tag ghcr.io/hyperledger/firefly-fabconnect:head \
2223
.

.github/workflows/go.yml

+1
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,5 @@ jobs:
4343
--label build_date=$(date -u +"%Y-%m-%dT%H:%M:%SZ") \
4444
--label tag=${{ steps.build_tag_generator.outputs.BUILD_TAG }} \
4545
--build-arg BASE_IMAGE=alpine:3.19 \
46+
--build-arg BUILD_IMAGE=golang:1.21-alpine3.19 \
4647
--tag ghcr.io/hyperledger/firefly-fabconnect:${{ steps.build_tag_generator.outputs.BUILD_TAG }} .

Dockerfile

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
ARG BASE_IMAGE
2+
ARG BUILD_IMAGE
23

3-
FROM golang:1.21-alpine3.19 AS fabconnect-builder
4+
FROM ${BUILD_IMAGE} AS fabconnect-builder
45
RUN apk add make
56
ADD . /fabconnect
67
WORKDIR /fabconnect

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ firefly-fabconnect: ${GOFILES}
2727
go-mod-tidy: .ALWAYS
2828
go mod tidy
2929
docker:
30-
docker build --build-arg BASE_IMAGE=alpine:3.19 -t hyperledger/firefly-fabconnect .
30+
docker build --build-arg BASE_IMAGE=alpine:3.19 --build-arg BUILD_IMAGE=golang:1.21-alpine3.19 -t hyperledger/firefly-fabconnect .
3131
build: firefly-fabconnect-nocgo firefly-fabconnect
3232
.ALWAYS: ;
3333
clean:

0 commit comments

Comments
 (0)