Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add HSM kms implementation #2105

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Add HSM kms implementation #2105

merged 2 commits into from
Oct 4, 2024

Conversation

gtebrean
Copy link
Contributor

@gtebrean gtebrean commented Oct 1, 2024

What does this PR do?

required

Where should the reviewer start?

required

Why is it needed?

required

Checklist

  • I've read the contribution guidelines.
  • I've added tests (if applicable).
  • I've added a changelog entry if necessary.

Signed-off-by: gtebrean <99179176+gtebrean@users.noreply.github.com>
Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add some test cases?

Signed-off-by: gtebrean <99179176+gtebrean@users.noreply.github.com>
@gtebrean
Copy link
Contributor Author

gtebrean commented Oct 2, 2024

Do we need to add some test cases?

can't be executed as a tes because will need to provide an AWS env with the KMS in order to can execute it, I tested it locally

Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gtebrean gtebrean merged commit 86df48c into main Oct 4, 2024
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants