Initial Mac version #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes NSColorTests, fails NSImageTests - probably due to size of image being different to iOS version.
|
This is amazeballs! I think we could just go ahead and merge it and fix the tests afterwards. I'm gonna have a look! Thanks for contributing to Hue, you are awesome! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version passes the NS version of the UIColorTests. However, it fails the NS version of the UIImageTests. This is possibly due to the size of the analysed image being different to the iOS version (see #5). I played around with some ideas but couldn't get the tests to pass so figured I'd enlist some help or advice through a pull request. The returned background, primary, secondary and detail colours are not far from the iOS versions but not close enough to pass the tests.