From 97673676c0e84912efd9589537d1a824e0ad7be8 Mon Sep 17 00:00:00 2001 From: Ivan Maidurov Date: Thu, 20 Jul 2023 17:13:18 +0200 Subject: [PATCH] fix(silentlogger): remove unnecessary fields --- core/silentzap/context.go | 6 +----- core/silentzap/logger.go | 6 +++--- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/core/silentzap/context.go b/core/silentzap/context.go index de9f16eb1..4af9152c3 100644 --- a/core/silentzap/context.go +++ b/core/silentzap/context.go @@ -3,7 +3,6 @@ package silentzap import ( "sync" - "go.uber.org/zap" "go.uber.org/zap/zapcore" ) @@ -16,12 +15,10 @@ type ( storedEntry struct { CheckedLogEntry *zapcore.CheckedEntry - Fields []zap.Field } ) -//nolint:unparam // taking zap into account we should have possibilities to store fields -func (c *SilentContext) store(entry *zapcore.CheckedEntry, fields ...zap.Field) { +func (c *SilentContext) store(entry *zapcore.CheckedEntry) { if c == nil { return } @@ -34,7 +31,6 @@ func (c *SilentContext) store(entry *zapcore.CheckedEntry, fields ...zap.Field) c.storedEntries, storedEntry{ CheckedLogEntry: entry, - Fields: fields, }, ) }() diff --git a/core/silentzap/logger.go b/core/silentzap/logger.go index bb8033cef..990c6cb9d 100644 --- a/core/silentzap/logger.go +++ b/core/silentzap/logger.go @@ -233,7 +233,7 @@ func (l *SilentLogger) Error(args ...interface{}) { if !logContext.isWritingAllowed() { currentEntries := logContext.get() for _, entry := range currentEntries { - entry.CheckedLogEntry.Write(entry.Fields...) + entry.CheckedLogEntry.Write() } } @@ -250,7 +250,7 @@ func (l *SilentLogger) Fatal(args ...interface{}) { if !logContext.isWritingAllowed() { currentEntries := logContext.get() for _, entry := range currentEntries { - entry.CheckedLogEntry.Write(entry.Fields...) + entry.CheckedLogEntry.Write() } } @@ -267,7 +267,7 @@ func (l *SilentLogger) Panic(args ...interface{}) { if !logContext.isWritingAllowed() { currentEntries := logContext.get() for _, entry := range currentEntries { - entry.CheckedLogEntry.Write(entry.Fields...) + entry.CheckedLogEntry.Write() } }