Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

8.0-RC1 Storing Geozones causes all free number fields to be read-only until restart #2251

Closed
b14ckyy opened this issue Nov 17, 2024 · 7 comments
Labels
Confirmed Bug has been confirmed by developer
Milestone

Comments

@b14ckyy
Copy link
Collaborator

b14ckyy commented Nov 17, 2024

Reproduce

  • Connect Configurator to FC
  • Open Mission Control
  • Create any Geozone if none present yet
  • Click on Store to FC and wait for reboot
  • Wait for reconnect
    Result: No text field can be directly edited like Altitudes, Distances etc.

Reconnect of FC does not fix
As a workaround, Configurator needs to be restarted entirely.
Normal Save and Reboot from other pages are not trigger the issue as far as I can tell.

Replicated in RC1 and Nightly inav-configurator-dev-20241117-65

Demo: https://youtu.be/hoj7qgpSJNk

@b14ckyy b14ckyy added the Confirmed Bug has been confirmed by developer label Nov 17, 2024
@b14ckyy b14ckyy added this to the 8.0 milestone Nov 17, 2024
@stronnag
Copy link
Collaborator

Does not happen here. After reboot, text fields are editable ... at least with the SITL as FC. Let me try a real one.

@b14ckyy
Copy link
Collaborator Author

b14ckyy commented Nov 17, 2024

I can replicate on 2 FCs and also got the same report from 2 users.
Are you on Windows or linux? Maybe only windows affected?

@stronnag
Copy link
Collaborator

Linux.
However, this looks strange ...
image

@stronnag
Copy link
Collaborator

stronnag commented Nov 17, 2024

There is no problem on Linux with editing fields after reboot with "real" FCs, so maybe it's a Windows issue.
(Local build vice binary from Github, in case that's relevant (should not be, it's RC1 either way).

@b14ckyy
Copy link
Collaborator Author

b14ckyy commented Nov 17, 2024

Yeah I think there is a confusion between ASL reference and Launch Alt reference for the validity check.
image

@Scavanger

@Scavanger
Copy link
Contributor

Scavanger commented Nov 19, 2024

Fix for sanity check: #2252

The bug that the fields (affects ALL(!) input fields even in other tabs!) are inactive after saving is strange, and as @stronnag said, only occurs under windows. I can't find a bug in the code. I haven't changed anything in the code and I guess it worked before.
Apparently the input fields lose their focus.
Workaround: Deactivate the Configurator window briefly (minimise, activate another window, etc.) then everything works again.

Found it: Native dialog boxes are broken in Electron, replaced the confirm box when geozones are saved with the one from electron. -> Fixed

@b14ckyy
Copy link
Collaborator Author

b14ckyy commented Nov 19, 2024

Fixed in #2252

@b14ckyy b14ckyy closed this as completed Nov 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Confirmed Bug has been confirmed by developer
Projects
None yet
Development

No branches or pull requests

3 participants