Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Wrong bounding box computing for negative elevation data #1945

Closed
mgermerie opened this issue Nov 8, 2022 · 1 comment · Fixed by #1993
Closed

Wrong bounding box computing for negative elevation data #1945

mgermerie opened this issue Nov 8, 2022 · 1 comment · Fixed by #1993

Comments

@mgermerie
Copy link
Contributor

mgermerie commented Nov 8, 2022

When displaying some negative elevation data in an ElevationLayer, the bounding boxes of tiles are clamped above -10 meters.
This is caused by this line when computing the minimal and maximal value of elevation data within a given tile.

This value has been hard coded to prevent an issue with geoportail elevation data. Along the coast line, these data contain isolated points with extremely low altitude (sometimes lower than the earth radius). The bounding sphere of the tiles is therefore huge, exceeding the sse threshold above which tiles are subdivided. It causes tiles along the coast line to be subdivided too much. This can be seen in the screenshot bellow.

Capture d’écran du 2022-11-08 17-33-27

Clamping the minimal elevation value of a tile prevents this. However, relevant negative elevation values should not be clamped.

The -10 hard coded value should be parametrized in the ElevationLayer creation, with a default value of -Infinity.

@jailln
Copy link
Contributor

jailln commented Nov 9, 2022

There is another one here :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants