Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: remove index.html local landing page #2478

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

HoloTheDrunk
Copy link
Contributor

@HoloTheDrunk HoloTheDrunk commented Dec 17, 2024

Description

Removed the content of the index page that only appears when serving itowns locally with webpack, instead opting to automatically redirect to the examples.

Motivation and Context

The index page was completely unmaintained and riddled with errors. This could mislead potential contributors and is just generally a bad first impression.
It also had the side-effect of making it infinitesimally more inconvenient to test iTowns locally by introducing the need to manually change the URL to point to the examples, and we can't have that.

Tested on Ubuntu 22.04.5 LTS x86_64 using Firefox 126.0.1 (64-bit)

@HoloTheDrunk HoloTheDrunk changed the title feat(index.html): auto-redirect to examples chore: remove index.html local landing page Dec 17, 2024
@HoloTheDrunk HoloTheDrunk requested a review from jailln December 17, 2024 15:10
@HoloTheDrunk HoloTheDrunk merged commit 1e171ff into iTowns:master Dec 17, 2024
9 checks passed
@HoloTheDrunk HoloTheDrunk deleted the bypass_index_page branch December 17, 2024 15:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants