Skip to content

fix: ordinal for nl not working #2011

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2022
Merged

fix: ordinal for nl not working #2011

merged 1 commit into from
Aug 12, 2022

Conversation

ctessier
Copy link
Contributor

@ctessier ctessier commented Aug 4, 2022 •
edited
Loading

In dutch locale, the ordinal doesn't show properly, some letters get interpreted.

Before the fix: ❌

dayjs().locale('nl').format('Do'); // 44e
dayjs('2022-08-23').locale('nl').format('Do'); // 230te

After the fix: ✔️

dayjs().locale('nl').format('Do'); // 4de
dayjs('2022-08-23').locale('nl').format('Do'); // 23ste

@codecov
Copy link

codecov bot commented Aug 12, 2022 •
edited
Loading

Codecov Report

Merging #2011 (1bac271) into dev (b5b7be1) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               dev     #2011   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          181       181           
  Lines         2074      2074           
  Branches       544       544           
=========================================
  Hits          2074      2074
Impacted Files Coverage Δ
src/locale/nl.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iamkun
Copy link
Owner

iamkun commented Aug 12, 2022

Thanks

@iamkun iamkun merged commit c93c85e into iamkun:dev Aug 12, 2022
iamkun pushed a commit that referenced this pull request Aug 12, 2022
@semantic-release-bot
chore(release): 1.11.5 [skip ci]
e3777ed 
## [1.11.5](v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([#2011](#2011)) ([c93c85e](c93c85e))
* wrong ordinal for french locale ([#2010](#2010)) ([dd192a7](dd192a7))
@iamkun
Copy link
Owner

iamkun commented Aug 12, 2022

🎉 This PR is included in version 1.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

BePo65 pushed a commit to BePo65/dayjs that referenced this pull request Oct 10, 2022
@semantic-release-bot @BePo65
chore(release): 1.11.5 [skip ci]
54164cc 
## [1.11.5](iamkun/dayjs@v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([iamkun#2011](iamkun#2011)) ([c93c85e](iamkun@c93c85e))
* wrong ordinal for french locale ([iamkun#2010](iamkun#2010)) ([dd192a7](iamkun@dd192a7))
ohsory1324 pushed a commit to ohsory1324/dayjs that referenced this pull request Dec 20, 2023
@semantic-release-bot @ohsory1324
chore(release): 1.11.5 [skip ci]
db9c94c 
## [1.11.5](iamkun/dayjs@v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([iamkun#2011](iamkun#2011)) ([c93c85e](iamkun@c93c85e))
* wrong ordinal for french locale ([iamkun#2010](iamkun#2010)) ([dd192a7](iamkun@dd192a7))
@mdfkbtc mdfkbtc mentioned this pull request May 19, 2024
Open
@mraible mraible mentioned this pull request May 20, 2024
Closed
@NOUIY NOUIY mentioned this pull request May 20, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request May 20, 2024
Open
@NOUIY NOUIY mentioned this pull request May 24, 2024
Open
@FlorentinTh FlorentinTh mentioned this pull request May 24, 2024
Open
@B0ub0 B0ub0 mentioned this pull request Jun 8, 2024
Open
@OATEF4313 OATEF4313 mentioned this pull request Jun 20, 2024
Open
@mdfkbtc mdfkbtc mentioned this pull request Jun 21, 2024
Open
@swayangjit swayangjit mentioned this pull request Jul 11, 2024
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Jul 17, 2024
Closed
This was referenced Jul 27, 2024
Open
Open
Open
Open
@otmaneEH otmaneEH mentioned this pull request Jul 30, 2024
Open
This was referenced Jul 31, 2024
Open
Open
Open
Open
@FlorentinTh FlorentinTh mentioned this pull request Aug 9, 2024
Open
@mdfkbtc mdfkbtc mentioned this pull request Aug 9, 2024
Open
@marinabs23 marinabs23 mentioned this pull request Aug 9, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
@flon-chou flon-chou mentioned this pull request Aug 15, 2024
Open
@NOUIY NOUIY mentioned this pull request Aug 21, 2024
Open
@JonasLang-dev JonasLang-dev mentioned this pull request Sep 7, 2024
Open
@lcf262412 lcf262412 mentioned this pull request Sep 9, 2024
Open
@marinabs23 marinabs23 mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Open
Open
Open
@NOUIY NOUIY mentioned this pull request Sep 23, 2024
Open
@mdfkbtc mdfkbtc mentioned this pull request Sep 24, 2024
Open
@Z-byte-prog Z-byte-prog mentioned this pull request Sep 28, 2024
Closed
@FlorentinTh FlorentinTh mentioned this pull request Sep 29, 2024
Open
@KaliforniaShell KaliforniaShell mentioned this pull request Oct 2, 2024
Merged
splashwizard pushed a commit to splashwizard/tracking-time that referenced this pull request Oct 21, 2024
@semantic-release-bot
chore(release): 1.11.5 [skip ci]
29b67d4 
## [1.11.5](iamkun/dayjs@v1.11.4...v1.11.5) (2022-08-12)

### Bug Fixes

* ordinal for nl not working ([#2011](iamkun/dayjs#2011)) ([c93c85e](iamkun/dayjs@c93c85e))
* wrong ordinal for french locale ([#2010](iamkun/dayjs#2010)) ([dd192a7](iamkun/dayjs@dd192a7))
@FlorentinTh FlorentinTh mentioned this pull request Oct 22, 2024
Open
@Jekyle9444 Jekyle9444 mentioned this pull request Nov 13, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctessier @iamkun