Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Grammarly autocorrections don't work #4579

Closed
churichard opened this issue Oct 8, 2021 · 1 comment · Fixed by #4669
Closed

Grammarly autocorrections don't work #4579

churichard opened this issue Oct 8, 2021 · 1 comment · Fixed by #4669
Labels

Comments

@churichard
Copy link

Description
Grammarly autocorrections don't seem to work anymore.

From looking at this PR, it seems like they did indeed work in a previous version of Slate. And I seem to recall them working not too long ago as well, so this is likely a regression.

Now when you select a correction, the text is inserted at the cursor position and does not overwrite the misspelled word.

Recording
grammarly

Sandbox
https://www.slatejs.org/examples/richtext

Steps
To reproduce the behavior:

  1. Go to https://www.slatejs.org/examples/richtext
  2. Install + enable Grammarly on the website
  3. Type a misspelled word
  4. Hover over the misspelled word and select a correction
  5. Observe that the correction is inserted at the cursor and does not overwrite the misspelled word

Expectation
Autocorrections should overwrite the misspelled word.

Environment

  • Slate Version: 0.66.6
  • Operating System: Windows
  • Browser: Chrome
@dylans
Copy link
Collaborator

dylans commented Nov 9, 2021

This looks like the same issue as the currently broken application of suggestions from spell checking.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants