Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Breakout Requests Functionality to New Adapter Module #223

Merged
merged 13 commits into from
Jul 19, 2018

Conversation

jeffwecan
Copy link
Member

@jeffwecan jeffwecan commented Jul 16, 2018

This PR is the first set of changes (technically second) meant to move #95 forward. It aims to move almost all calls into the requests module to a new adapter class.

  • This allows some code to be moved out of the Client class. The ultimate goal is to greatly reduce the amount of code that needs to be maintained directly in the Client class.
  • It also enables end-users to more easily override or modify the behavior surrounding requests without needing to subclass the Client class directly.
  • Existing call sites have been left in place. However the now will include deprecation warnings for any users that had been calling these (mostly private) methods directly.

@jeffwecan jeffwecan mentioned this pull request Jul 16, 2018
@jeffwecan jeffwecan merged commit fa44c68 into master Jul 19, 2018
@jeffwecan jeffwecan deleted the adapter_pattern branch July 19, 2018 11:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant