Shell script with fzf reload to toggle between two sets of files, use in fzf-lua?

[csswright]

I have a shell (bash) script which has runs fzf to show a set of files where upon selection, it opens the file for edit. Bound to fzf-lua, it works as expected for use in Neovim:

vim.keymap.set("", "<leader>F", function()
  fzf_lua.fzf_exec("e", {
    previewer = "builtin",
    actions = {
      ["default"] = actions.file_edit,
    },
  })

which upon actions.file_edit presumably just edits the selected file, terminating the bash script.

I then implement toggling with reload for an alternative set of files to edit, toggled with Ctrl-r to switch between the two sets in the script:

# the cmd is not this simple, just an example to keep it short
cmd() {
  if [[ "$1" == '--repo' ]]; then
    fd . "$HOME/dir1"
  else
    fd . "$HOME/dir2"
  fi
}

export -f cmd

printf "%s\n" "${files[@]}" |
    SHELL=/usr/bin/bash fzf --scheme=path \
      --prompt="Files (user) > " \
      --bind 'ctrl-r:transform:[[ ! $FZF_PROMPT == "Files (user) > " ]] &&
      echo "change-prompt(Files (user) > )+reload(cmd)" ||
      echo "change-prompt(Files (repo) > )+reload(cmd --repo)"' \
      --preview "([ -f {} ] && (bat --style=numbers --color=always {} || cat {})) || ([ -d {} ] && (tree -C {} | less)) || echo {} 2> /dev/null | head -200" \
      "$@"

which works from the terminal, but Ctrl -r doesn't do anything in fzf-lua. I see there is action-reload, but is this applicable to a shell script that already implements the reload? I don't know much programming at all so I stuck with bash script. Or should the bash script be modified to just print the appropriate set of files and have Lua do the conditional and reloading logic? Would appreciate an example if this is the way. I would prefer a solution that uses fzf reload so it uses the same process instead of calling the bash script every time it reloads.

Other questions:

Can fzf-lua respect the --prompt used in the shell script?

Unrelated: In require('fzf-lua').path.entry_to_file(selected[1], o), rg_glob_fn = function(query, o), etc. What does o argument mean? It's standards for "options" but what from what available options and how can it be used?

Much appreciated.

[ibhagwan]

which works from the terminal, but Ctrl -r doesn't do anything in fzf-lua. I see there is action-reload, but is this applicable to a shell script that already implements the reload? I don't know much programming at all so I stuck with bash script. Or should the bash script be modified to just print the appropriate set of files and have Lua do the conditional and reloading logic? Would appreciate an example if this is the way. I would prefer a solution that uses fzf reload so it uses the same process instead of calling the bash script every time it reloads.

you’ll can use the same script most likely if you send it via opts.cli_args but I personally would transform this to a “reload action that opens a new picker: actions = { ["ctrl-r”] = { fn = function(…) end, reload = true } }, search the issues for toggles and you’ll find ample examples of that.

Can fzf-lua respect the --prompt used in the shell script?

It should unless you’re using one of the profiles that modifies the prompt, in that case send opts.prompt instead.

Unrelated: In require('fzf-lua').path.entry_to_file(selected[1], o), rg_glob_fn = function(query, o), etc. What does o argument mean? It's standards for "options" but what from what available options and how can it be used?

o are the picker options, default ones plus the ones you added via setup/call.

[csswright]

personally would transform this to a “reload action that opens a new picker: actions = { ["ctrl-r”] = { fn = function(…) end, reload = true } }, search the issues for toggles and you’ll find ample examples of that.

I attempted the following with little lua knowledge, but on ctrl-r it gives an error (I didn't come across an example with fzf_exec, maybe it's different than an example with the builtin pickers):

Error executing vim.schedule lua callback: .../.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:254: ...heng/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:603: inv
alid value (boolean) at index 1 in table for 'concat'
stack traceback:
        [builtin#36]: at 0x755320ae14e0
        .../.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:254: in function 'fzf_exec'
        .../.config/nvim/lua/gc/plugins/fzf-lua.lua:28: in function 'fn'
        .../.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:1186: in function 'fn'
        .../.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:123: in function 'fn'
        .../.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:79: in function <.../.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/shell.lua:78>

e --list is a shell command to print one set of files and e --repo --list is for the other set. Full config:

return {
  "ibhagwan/fzf-lua",
  opts = function()
    local fzf_lua = require("fzf-lua")
    local actions = fzf_lua.actions
    _G.epicker = function(_, opts)
      opts = opts or {}
      opts.debug = true
      opts.cmd = opts.cmd or "e --list"
      opts.previewer = "builtin"
      vim.print(opts)
      if opts.cmd:match("e --repo --list") then
        opts.cmd = "e --list"
      else
        opts.cmd = "e --repo --list"
      end
      opts.actions = {
        ["ctrl-r"] = {
          fn = _G.epicker,
          reload = true,
        },
        ["default"] = actions.file_edit,
        ["ctrl-s"] = actions.file_split,
        ["ctrl-v"] = actions.file_vsplit,
        ["ctrl-t"] = actions.file_tabedit,
        ["alt-q"] = actions.file_sel_to_qf,
      }
      fzf_lua.fzf_exec(opts.cmd, opts)
    end
  end,
  config = function(_, opts)
    local fzf_lua = require("fzf-lua")
    -- local actions = fzf_lua.actions
    fzf_lua.setup(opts)
    vim.keymap.set("", "<leader>e", _G.epicker, { desc = "freq files" })
  end,
}

On latest fzf-lua version, any ideas?

Also curious if the custom picker needs to be a global variable and if it can inherit files mappings (I copied the its defaults here).

Thank you.

[ibhagwan]

On latest fzf-lua version, any ideas?

the exception seems to be in the color table concat unrelated to your code, maybe you have it setup in global or via vim.g.fzf_colors.

Also curious if the custom picker needs to be a global variable and if it can inherit files mappings (I copied the its defaults here).

You can setup _actions as a function that returns the defaults and it will be merged, take a look in defaults.lua.

What I’m wondering is if your picker is for files and uses files actions/previewer why not use _G.FzfLua.files({ cwd = "…" }) with your custom command?

[csswright]

the exception seems to be in the color table concat unrelated to your code, maybe you have it setup in global or via vim.g.fzf_colors.

I reproduced the issue using minimal config: init.lua (lazy.nvim), lua/test/plugins/fzf-lua.lua and wiped FZF_DEFAULT_OPTS, checkhealth reports:

fzf_lua: health#fzf_lua#check

fzf-lua [required] ~
- OK 'fzf' `0.57.0 (0476a65f)`
- OK 'git' `git version 2.48.1`
- OK 'rg' `ripgrep 14.1.1`
- OK 'fd' `fd 10.2.0`

fzf-lua [optional] ~
- OK `nvim-web-devicons` found
- OK 'rg' `ripgrep 14.1.1`
- OK 'fd' `fd 10.2.0`
- OK 'bat' `bat 0.25.0 (v0.25.0-modified)`

fzf-lua [optional:media] ~
- WARNING 'viu' not found
- WARNING 'chafa' not found
- WARNING 'ueberzugpp' not found

fzf-lua [env] ~
- OK `FZF_DEFAULT_OPTS` is not set
- OK `FZF_DEFAULT_OPTS_FILE` is not set

nvim: v0.10.3,

What I’m wondering is if your picker is for files and uses files actions/previewer why not use _G.FzfLua.files({ cwd = "…" }) with your custom command?

I use the wrapper shell script often in the CLI and prefer to manage the logic to create the sets of files in one place rather than port it into Lua and manage both (the collection of files come from different types of sources and some filtering logic so a bit more involved than what my Lua is capable of).

I have no faith in my Lua so could very well be just be an issue with my config posted.

[csswright]

Hmm, it's not working for me even in mini.sh, tried both Neovim 0.10.3 and the recent 0.10.4 and fzf 0.57.0,

export FZF_DEFAULT_OPTS= 
sh -c "$(curl -s https://raw.githubusercontent.com/ibhagwan/fzf-lua/main/scripts/mini.sh)"

Everything works as expected until Ctrl-y to reload and it shows that error.

-- you aren’t returning a table from your opts, not sure why you did that?

There's a proper fzf-lua opts table that gets returned after the picker is defined in the opts section, I must've accidentally stripped that off in the pastebin removing comments.

I'm just perplexed why I'm having issues even with the stripped down mini.sh so it appears not related to my Neovim config after all but that just raises more questions given my environment seems fine... I'm on Arch Linux.

[ibhagwan]

That is strange indeed, if this was more prevalent I’m sure we would’ve seen this popup more in “issues”, more confusing is the fact it’s crashing in fzf_color building… my next guess would’ve been a vim.g.fzf_colors set by the color scheme but you tried with mini.sh so we can rule this out.

Does any other reload action such as alt-i/f/h in files or ctrl-g in grep work for you?

I’m sure it’s something silly we’re missing here.

[csswright]

Does any other reload action such as alt-i/f/h in files or ctrl-g in grep work for you?

Yep, all those actions work as expected with the builtin pickers.

[ibhagwan]

@csswright, had more time to dig into this properly, fixed in 8af88e5.

[csswright]

EDIT: This was fixed :)

---

@ibhagwan

Nice, toggling works now. In the ls toggle example and my custom toggle, actions.file_edit and actions.file_sel_to_qf doesn't work after toggling, even if toggling back to the original list of items. They work prior to toggling.

1. After toggling, for ["default"] = actions.file_edit, it's not opening the selected file. (EDIT: adding ["enter"] = actions.file_edit, seems to fix this but my understanding is default/enter/ are equivalent?).

2. After toggling, for actions.file_sel_to_qf, it has the error:

    [Fzf-lua] fn_selected threw an error: ...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/actions.lua:304: attempt to concatenate field 'cmd' (a nil value)
    stack traceback:
    ^I...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:251: in function '__concat'
    ^I...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/actions.lua:304: in function 'sel_to_qf'
    ^I...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/actions.lua:335: in function 'action'
    ^I...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/actions.lua:120: in function 'act'
    ^I...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:157: in function 'fn_selected'
    ^I...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:244: in function <...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:243>
    ^I[C]: in function 'xpcall'
    ^I...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:243: in function <...g/.local/share/nvim/lazy/fzf-lua/lua/fzf-lua/core.lua:235>
   

The builtin file_split and tabedit actions have no issues and haven't tested other builtin actions.

[ibhagwan]

1. After toggling, for ["default"] = actions.file_edit, it's not opening the selected file. (EDIT: adding ["enter"] = actions.file_edit, seems to fix this but my understanding is default/enter/ are equivalent?).

I renamed default to enter a while ago to match fzf defaults, the backward compact code should run in config.normalize_opts, I can check what happens there.

2. After toggling, for actions.file_sel_to_qf, it has the error:
   The builtin file_split and tabedit actions have no issues and haven't tested other builtin actions.

Apologies for the delays I’ve been out of pocket, I would consider both of these bugs, please open an issue (one for both, you can skip the template info) so I’ll have tracking and I’ll fix it when I get a chance.