Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use bash in entrypoint #4

Merged
merged 2 commits into from
Feb 24, 2020
Merged

Use bash in entrypoint #4

merged 2 commits into from
Feb 24, 2020

Conversation

lucianposton
Copy link
Contributor

Added bash to Dockerfile to write the script in bash. Figured it'd be cleaner than sh acrobatics to do recursive globstar and fixing the worksplitting.

Demo of #2 and #3 fixed:

lol2

@lucianposton
Copy link
Contributor Author

IIRC, adding bash to the image increased the size of the 116MB image by 2.1MB.

@lucianposton lucianposton force-pushed the master branch 4 times, most recently from 32c2629 to 4d720f5 Compare February 19, 2020 00:30
@ibiqlik
Copy link
Owner

ibiqlik commented Feb 24, 2020

Thanks @lucianposton I'll review and do some tests ASAP. 2.1 MB increase is peanuts.

@ibiqlik ibiqlik merged commit 420199a into ibiqlik:master Feb 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ibiqlik ibiqlik ibiqlik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucianposton @ibiqlik