Building tests for feature/refactor fails with JDK17

[penguineer]

I'm opening this issue as a follow-up to the discussion in #53, as we went quite off-topic there.

The build of branch feature/refactor fails with OpenJDK 17 like this:

→ make
./gradlew test

> Task :ical4j-connector-api:compileJava
Note: /home/tux/Projekte/ical4j-connector/ical4j-connector-api/src/main/java/org/ical4j/connector/local/LocalCalendarCollection.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :ical4j-connector-dav:compileJava
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/ScheduleResponse.java:111: warning: [removal] Float(String) in Float has been deprecated and marked for removal
this.requestStatusCode = new Float(split[0]).floatValue();
^
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/AbstractDavObjectCollection.java:181: warning: [removal] Long(long) in Long has been deprecated and marked for removal
return new Long(0);
^
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/AbstractDavObjectCollection.java:196: warning: [removal] Long(long) in Long has been deprecated and marked for removal
return new Long(0);
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 warnings

> Task :ical4j-connector-dav:compileTestJava
Note: /home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/test/java/org/ical4j/connector/dav/CalendarCollectionTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :ical4j-connector-dav:compileTestGroovy FAILED
startup failed:
General error during conversion: PermittedSubclasses requires ASM9

java.lang.UnsupportedOperationException: PermittedSubclasses requires ASM9
at groovyjarjarasm.asm.ClassVisitor.visitPermittedSubclass(ClassVisitor.java:266)
at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:683)
at groovyjarjarasm.asm.ClassReader.accept(ClassReader.java:401)
at org.codehaus.groovy.ast.decompiled.AsmDecompiler.parseClass(AsmDecompiler.java:81)
at org.codehaus.groovy.control.ClassNodeResolver.findDecompiled(ClassNodeResolver.java:251)
at org.codehaus.groovy.control.ClassNodeResolver.tryAsLoaderClassOrScript(ClassNodeResolver.java:189)
at org.codehaus.groovy.control.ClassNodeResolver.findClassNode(ClassNodeResolver.java:169)
at org.codehaus.groovy.control.ClassNodeResolver.resolveName(ClassNodeResolver.java:125)
at org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClassNullable(AsmReferenceResolver.java:57)
at org.codehaus.groovy.ast.decompiled.AsmReferenceResolver.resolveClass(AsmReferenceResolver.java:44)
at org.codehaus.groovy.ast.decompiled.TypeSignatureParser.visitEnd(TypeSignatureParser.java:110)
at groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:206)
at groovyjarjarasm.asm.signature.SignatureReader.parseType(SignatureReader.java:235)
at groovyjarjarasm.asm.signature.SignatureReader.accept(SignatureReader.java:114)
at org.codehaus.groovy.ast.decompiled.MemberSignatureParser.createMethodNode(MemberSignatureParser.java:97)
at org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lambda$createMethodNode$1(DecompiledClassNode.java:230)
at org.codehaus.groovy.ast.decompiled.DecompiledClassNode.createMethodNode(DecompiledClassNode.java:236)
at org.codehaus.groovy.ast.decompiled.DecompiledClassNode.lazyInitMembers(DecompiledClassNode.java:203)
at org.codehaus.groovy.ast.decompiled.DecompiledClassNode.getDeclaredField(DecompiledClassNode.java:116)
at org.apache.groovy.ast.tools.ClassNodeUtils.getField(ClassNodeUtils.java:412)
at org.apache.groovy.ast.tools.ClassNodeUtils.getField(ClassNodeUtils.java:417)
at org.codehaus.groovy.control.StaticImportVisitor.findStaticField(StaticImportVisitor.java:552)
at org.codehaus.groovy.control.StaticImportVisitor.findStaticFieldOrPropAccessorImportFromModule(StaticImportVisitor.java:436)
at org.codehaus.groovy.control.StaticImportVisitor.transformVariableExpression(StaticImportVisitor.java:223)
at org.codehaus.groovy.control.StaticImportVisitor.transform(StaticImportVisitor.java:124)
at org.codehaus.groovy.ast.expr.Expression.transformExpressions(Expression.java:49)
at org.codehaus.groovy.ast.expr.ArgumentListExpression.transformExpression(ArgumentListExpression.java:66)
at org.codehaus.groovy.control.StaticImportVisitor.transform(StaticImportVisitor.java:142)
at org.codehaus.groovy.control.StaticImportVisitor.transformMethodCallExpression(StaticImportVisitor.java:248)
at org.codehaus.groovy.control.StaticImportVisitor.transform(StaticImportVisitor.java:133)
at org.codehaus.groovy.control.StaticImportVisitor.transformMethodCallExpression(StaticImportVisitor.java:246)
at org.codehaus.groovy.control.StaticImportVisitor.transform(StaticImportVisitor.java:133)
at org.codehaus.groovy.control.StaticImportVisitor.transformMethodCallExpression(StaticImportVisitor.java:246)
at org.codehaus.groovy.control.StaticImportVisitor.transform(StaticImportVisitor.java:133)
at org.codehaus.groovy.ast.expr.Expression.transformExpressions(Expression.java:49)
at org.codehaus.groovy.ast.expr.ArgumentListExpression.transformExpression(ArgumentListExpression.java:66)
at org.codehaus.groovy.control.StaticImportVisitor.transform(StaticImportVisitor.java:142)
at org.codehaus.groovy.control.StaticImportVisitor.transformMethodCallExpression(StaticImportVisitor.java:248)
at org.codehaus.groovy.control.StaticImportVisitor.transform(StaticImportVisitor.java:133)
at org.codehaus.groovy.ast.ClassCodeExpressionTransformer.visitExpressionStatement(ClassCodeExpressionTransformer.java:108)
at org.codehaus.groovy.ast.stmt.ExpressionStatement.visit(ExpressionStatement.java:40)
at org.codehaus.groovy.ast.CodeVisitorSupport.visitBlockStatement(CodeVisitorSupport.java:86)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitBlockStatement(ClassCodeVisitorSupport.java:164)
at org.codehaus.groovy.ast.stmt.BlockStatement.visit(BlockStatement.java:69)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClassCodeContainer(ClassCodeVisitorSupport.java:138)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitConstructorOrMethod(ClassCodeVisitorSupport.java:111)
at org.codehaus.groovy.ast.ClassCodeExpressionTransformer.visitConstructorOrMethod(ClassCodeExpressionTransformer.java:66)
at org.codehaus.groovy.control.StaticImportVisitor.visitConstructorOrMethod(StaticImportVisitor.java:108)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitMethod(ClassCodeVisitorSupport.java:106)
at org.codehaus.groovy.ast.ClassNode.visitMethods(ClassNode.java:1099)
at org.codehaus.groovy.ast.ClassNode.visitContents(ClassNode.java:1092)
at org.codehaus.groovy.ast.ClassCodeVisitorSupport.visitClass(ClassCodeVisitorSupport.java:52)
at org.codehaus.groovy.control.CompilationUnit.lambda$addPhaseOperations$3(CompilationUnit.java:209)
at org.codehaus.groovy.control.CompilationUnit$IPrimaryClassNodeOperation.doPhaseOperation(CompilationUnit.java:942)
at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:671)
at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:635)
at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:610)
at org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:270)
at org.gradle.api.internal.tasks.compile.ApiGroovyCompiler.execute(ApiGroovyCompiler.java:64)
at org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:97)
at org.gradle.api.internal.tasks.compile.GroovyCompilerFactory$DaemonSideCompiler.execute(GroovyCompilerFactory.java:76)
at org.gradle.api.internal.tasks.compile.daemon.AbstractDaemonCompiler$CompilerWorkAction.execute(AbstractDaemonCompiler.java:135)
at org.gradle.workers.internal.DefaultWorkerServer.execute(DefaultWorkerServer.java:63)
at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:49)
at org.gradle.workers.internal.AbstractClassLoaderWorker$1.create(AbstractClassLoaderWorker.java:43)
at org.gradle.internal.classloader.ClassLoaderUtils.executeInClassloader(ClassLoaderUtils.java:97)
at org.gradle.workers.internal.AbstractClassLoaderWorker.executeInClassLoader(AbstractClassLoaderWorker.java:43)
at org.gradle.workers.internal.IsolatedClassloaderWorker.run(IsolatedClassloaderWorker.java:49)
at org.gradle.workers.internal.IsolatedClassloaderWorker.run(IsolatedClassloaderWorker.java:30)
at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:87)
at org.gradle.workers.internal.WorkerDaemonServer.run(WorkerDaemonServer.java:56)
at org.gradle.process.internal.worker.request.WorkerAction$1.call(WorkerAction.java:138)
at org.gradle.process.internal.worker.child.WorkerLogEventListener.withWorkerLoggingProtocol(WorkerLogEventListener.java:41)
at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:135)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:414)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
at java.base/java.lang.Thread.run(Thread.java:833)

1 error


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ical4j-connector-dav:compileTestGroovy'.
> Compilation failed; see the compiler error output for details.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s
9 actionable tasks: 9 executed
make: *** [Makefile:19: test] Error 1

When I use OpenJDK 11 I get this:

→ make build
./gradlew build

> Task :ical4j-connector-api:compileJava
Note: /home/tux/Projekte/ical4j-connector/ical4j-connector-api/src/main/java/org/ical4j/connector/local/LocalCalendarCollection.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :ical4j-connector-dav:compileJava
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

> Task :ical4j-connector-dav:javadoc
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/AbstractDavObjectStore.java:164: warning - Tag @author cannot be used in method documentation.  It can only be used in the following types of documentation: overview, module, package, class/interface.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavCalendarStore.java:130: warning - @inheritDoc used but addCollection(String, DavPropertySet) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavCalendarStore.java:158: warning - @inheritDoc used but merge(String, CalendarCollection) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavCalendarStore.java:130: warning - @inheritDoc used but addCollection(String, DavPropertySet) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavCalendarStore.java:158: warning - @inheritDoc used but merge(String, CalendarCollection) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavCalendarStore.java:172: warning - Tag @author cannot be used in method documentation.  It can only be used in the following types of documentation: overview, module, package, class/interface.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavCalendarStore.java:194: warning - Tag @author cannot be used in method documentation.  It can only be used in the following types of documentation: overview, module, package, class/interface.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavCalendarStore.java:314: warning - Tag @author cannot be used in method documentation.  It can only be used in the following types of documentation: overview, module, package, class/interface.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavSupport.java:63: warning - invalid usage of tag <
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavSupport.java:63: warning - invalid usage of tag >
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavSupport.java:68: warning - invalid usage of tag <
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavSupport.java:68: warning - invalid usage of tag >
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavCollection.java:144: warning - @inheritDoc used but export() does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavCollection.java:144: warning - @inheritDoc used but export() does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavStore.java:107: warning - @inheritDoc used but addCollection(String, DavPropertySet) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavStore.java:134: warning - @inheritDoc used but merge(String, CalendarCollection) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavStore.java:107: warning - @inheritDoc used but addCollection(String, DavPropertySet) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavStore.java:134: warning - @inheritDoc used but merge(String, CalendarCollection) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavStore.java:148: warning - Tag @author cannot be used in method documentation.  It can only be used in the following types of documentation: overview, module, package, class/interface.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavStore.java:166: warning - Tag @author cannot be used in method documentation.  It can only be used in the following types of documentation: overview, module, package, class/interface.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavSupport.java:63: warning - invalid usage of tag <
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavSupport.java:63: warning - invalid usage of tag >
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavSupport.java:68: warning - invalid usage of tag <
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavSupport.java:68: warning - invalid usage of tag >
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavCalendarStore.java:130: warning - @inheritDoc used but addCollection(String, DavPropertySet) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavStore.java:107: warning - @inheritDoc used but addCollection(String, DavPropertySet) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavCollection.java:144: warning - @inheritDoc used but export() does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CalDavCalendarStore.java:158: warning - @inheritDoc used but merge(String, CalendarCollection) does not override or implement any method.
/home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/main/java/org/ical4j/connector/dav/CardDavStore.java:134: warning - @inheritDoc used but merge(String, CalendarCollection) does not override or implement any method.
29 warnings

> Task :ical4j-connector-dav:compileTestJava
Note: /home/tux/Projekte/ical4j-connector/ical4j-connector-dav/src/test/java/org/ical4j/connector/dav/CalendarCollectionTest.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :ical4j-connector-dav:test

BaikalDavClientIntegrationTest > test client authentication FAILED
java.lang.RuntimeException at GetSupportedFeatures.java:14

BaikalDavClientIntegrationTest > test create collection FAILED
org.apache.jackrabbit.webdav.DavException at BaseDavRequest.java:207

BaikalDavClientIntegrationTest > test get collection FAILED
org.apache.jackrabbit.webdav.DavException at BaseDavRequest.java:207

BaikalDavClientIntegrationTest > test propfind all FAILED
org.spockframework.runtime.ConditionFailedWithExceptionError at AbstractDavClientIntegrationTest.groovy:162
Caused by: java.lang.RuntimeException at AbstractResponseHandler.java:70

BaikalIntegrationTest > test client authentication FAILED
org.spockframework.runtime.ConditionFailedWithExceptionError at BaikalIntegrationTest.groovy:15
Caused by: java.lang.RuntimeException at BaikalIntegrationTest.groovy:15

BaikalObjectStoreIntegrationTest > test find calendar home set FAILED
java.lang.RuntimeException at GetSupportedFeatures.java:14

BaikalObjectStoreIntegrationTest > test calendar creation FAILED
java.lang.RuntimeException at GetSupportedFeatures.java:14

BedeworkObjectStoreIntegrationTest > test find calendar home set FAILED
java.lang.RuntimeException at GetSupportedFeatures.java:14

BedeworkObjectStoreIntegrationTest > test calendar creation FAILED
java.lang.RuntimeException at GetSupportedFeatures.java:14

CalDavLocatorFactoryTest > test locator creation from workspace and resource path > org.ical4j.connector.dav.CalDavLocatorFactoryTest.test locator creation from workspace and resource path [pathResolver: BAIKAL, prefix: https://www.example.com/dav/dav.php, href: https://www.example.com/dav/dav.php/admin/testcal, workspacePath: /admin, workspaceName: admin, path: /calendars/testcal, resourcePath: /admin/testcal, #5] FAILED
org.spockframework.runtime.SpockComparisonFailure at CalDavLocatorFactoryTest.groovy:56

CalDavLocatorFactoryTest > test locator creation from workspace and resource path > org.ical4j.connector.dav.CalDavLocatorFactoryTest.test locator creation from workspace and resource path [pathResolver: GCAL, prefix: https://apidata.googleusercontent.com/caldav/v2, href: https://apidata.googleusercontent.com/caldav/v2/calid/events, workspacePath: /calid, workspaceName: calid, path: /calid/events, resourcePath: null, #6] FAILED
org.spockframework.runtime.SpockComparisonFailure at CalDavLocatorFactoryTest.groovy:59

CalDavLocatorFactoryTest > test locator creation from workspace and resource path > org.ical4j.connector.dav.CalDavLocatorFactoryTest.test locator creation from workspace and resource path [pathResolver: SOGO, prefix: https://www.example.com/SOGo/dav, href: https://www.example.com/SOGo/dav/admin/testcal, workspacePath: /admin, workspaceName: admin, path: /testcal, resourcePath: /admin/testcal, #7] FAILED
org.spockframework.runtime.SpockComparisonFailure at CalDavLocatorFactoryTest.groovy:56

RadicaleCalDavResourceIntegrationTest > test get property names FAILED
java.lang.RuntimeException at AbstractResponseHandler.java:70

RadicaleObjectStoreIntegrationTest > test find calendar home set FAILED
java.lang.RuntimeException at CalDavCalendarStore.java:186

RadicaleObjectStoreIntegrationTest > test calendar creation FAILED
org.ical4j.connector.ObjectStoreException at CalDavCalendarCollection.java:118
Caused by: org.apache.jackrabbit.webdav.DavException at BaseDavRequest.java:207

58 tests completed, 15 failed, 4 skipped

> Task :ical4j-connector-dav:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':ical4j-connector-dav:test'.
> There were failing tests. See the report at: file:///home/tux/Projekte/ical4j-connector/ical4j-connector-dav/build/reports/tests/test/index.html

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 32s
17 actionable tasks: 17 executed
make: *** [Makefile:22: build] Error 1

[benfortuna]

Ok thanks. I think there are a lot more warnings with JDK17, but ultimately the result is the same - 15 tests are failing, which I think is the same in my local environment.

For now you can build without the tests if you want to create the jars:

./gradlew build -x test

[penguineer]

That helped, thank you! I now have a working build of feature/refactor. :)