Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[TASK] Serpent interface should be upgraded to process criticality calcs too (not only burnup) #2289

Closed
10 tasks done
alfoa opened this issue Mar 27, 2024 · 1 comment · Fixed by #2290
Closed
10 tasks done
Assignees
Labels
external interfaces priority_minor task This tag should be used for any new capability, improvement or enanchment

Comments

@alfoa
Copy link
Collaborator

alfoa commented Mar 27, 2024


Issue Description

Is your feature request related to a problem? Please describe.
Serpent interface currently only supports depletion calculation. An upgrade to support eigen/criticality calc is desirable

Describe the solution you'd like
Modification of the interface to allow perturbation/usage for both burnup and criticality calc

Describe alternatives you've considered
Manual sampling (external from RAVEN)


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@alfoa alfoa added priority_minor task This tag should be used for any new capability, improvement or enanchment external interfaces labels Mar 27, 2024
@alfoa alfoa mentioned this issue Mar 27, 2024
9 tasks
@alfoa alfoa self-assigned this Mar 29, 2024
@wangcj05
Copy link
Collaborator

wangcj05 commented Apr 3, 2024

Issue closure checklist is good.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
external interfaces priority_minor task This tag should be used for any new capability, improvement or enanchment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants