Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Manage auto tune config #44

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Conversation

mikstew
Copy link
Contributor

@mikstew mikstew commented Aug 7, 2023

Using the module to create an OpenSearch cluster resulted in a cluster with auto-tune disabled. This results in needing to clickops the configuration to enable it, which means it is not tracked in terraform.

This PR allows management of the auto-tune configuration.

https://registry.terraform.io/providers/hashicorp/aws/5.11.0/docs/resources/opensearch_domain#auto_tune_options

mstewart7 and others added 4 commits August 9, 2023 13:46
Signed-off-by: Mikio Stewart <44074221+mikstew@users.noreply.github.com>
@amontalban
Copy link
Contributor

@mikstew looks like this also have the logging feature you did in #45, maybe it would be better to clean this PR so it is easier to merge I think.

Thanks for doing this because I was in the need for the same (As the logging part).

@mikstew
Copy link
Contributor Author

mikstew commented Aug 31, 2023

@amontalban
I opted to just merge both PRs to main on my fork and just use it as the source for the module, as it didn't look like these PRs were going to get merged. I left these open in case others wanted to do the same.

@steveteuber steveteuber force-pushed the manage-auto-tune-config branch from 8b93c46 to 593fd1c Compare September 1, 2023 13:43
@steveteuber steveteuber merged commit 8e4afdc into idealo:main Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants