fix(server): resolve deadlock during concurrent segment reads #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetz
previously approved these changes
Feb 15, 2025
hubcio
force-pushed
the
fix-deadlock-on-reading
branch
7 times, most recently
from
1d837b7 to
87b2d72
Compare
spetz
previously approved these changes
Feb 16, 2025
numinnex
reviewed
Feb 16, 2025
hubcio
force-pushed
the
fix-deadlock-on-reading
branch
from
7fbd5ef to
f64629a
Compare
This commit addresses a deadlock issue in file reading operations by refactoring the code to use `Arc<File>` instead of `RwLock<Option<File>>`. The changes ensure that file operations are performed in a non-blocking manner using `spawn_blocking` and `read_exact_at`. This improves the concurrency and efficiency of file access, particularly in scenarios where multiple tasks are reading from the same file concurrently. The commit also includes error handling improvements for better diagnostics and robustness. Besides that, posix_fadvise(sequential) is added for segment files to improve page cache utilization.
hubcio
force-pushed
the
fix-deadlock-on-reading
branch
from
f64629a to
eb9972f
Compare
numinnex
approved these changes
Feb 16, 2025
spetz
approved these changes
Feb 16, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a deadlock issue in file reading operations by
refactoring the code to use
Arc<File>instead ofRwLock<Option<File>>.The changes ensure that file operations are performed in a non-blocking
manner using
spawn_blockingandread_exact_at. This improves theconcurrency and efficiency of file access, particularly in scenarios
where multiple tasks are reading from the same file concurrently. The
commit also includes error handling improvements for better diagnostics
and robustness.
Besides that,
posix_fadvise(sequential)is added for segment filesto improve page cache utilization.