fix: add optional arguments to signatures #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the commands are run with extra arguments without them being defined the command fails. This fix allows calling the `pre-push` and `prepare-commit-msg` hooks with all their arguments while still retaining the old behavior since the arguments are optional. Reference: https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks closes igorsgm#31
PR Summary
|
|
+1 |
|
+1 |
|
heyy is this pr not gonna merged ? |
|
@igorsgm, are you still maintaining this package? If not, I might be open to taking over as the maintainer. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the commands are run with extra arguments without them being defined the command fails. This fix allows calling the
pre-pushandprepare-commit-msghooks with all their arguments while still retaining the old behavior since the arguments are optional.Reference: https://git-scm.com/book/en/v2/Customizing-Git-Git-Hooks
closes #31 #36