Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Panic "Image index out of bounds" in ImageBuffer::get_pixel() #878

Closed
Shnatsel opened this issue Mar 2, 2019 · 5 comments
Closed

Panic "Image index out of bounds" in ImageBuffer::get_pixel() #878

Shnatsel opened this issue Mar 2, 2019 · 5 comments

Comments

@Shnatsel
Copy link
Contributor

Shnatsel commented Mar 2, 2019

The following GIF images trigger a panic in ImageBuffer::get_pixel() when decoded: gif-oob.zip

Code to reproduce the issue is exactly the same as in #876. Found with AFL.rs, tested on git commit 865d2fc

@fintelia
Copy link
Contributor

fintelia commented Sep 16, 2019

I think this may be resolved? I tried running the code below and didn't see any panics (I had to rename the files to ".gif" to make the open function work):

fn main() {
    println!("{:?}", image::open("17d85872e1bb51147e968648399c8e23fda23c63.gif").err());
    println!("{:?}", image::open("2b6bf5f87834ff9c8962a0f0229404b4b8a7cae5.gif").err());
}

@Shnatsel
Copy link
Contributor Author

The exact code to reproduce the issue is listed in #876, please try that.

@fintelia
Copy link
Contributor

I still wasn't able to reproduce this issue. I was however able to reproduce issue #877 which uses the same code, I'll post my findings about that in a bit

@Shnatsel
Copy link
Contributor Author

As soon as all the known panics in GIF decoder are fixed or found not reproducible, I'll re-run the fuzzer and it will probably find several more.

@HeroicKatora
Copy link
Member

Can't reproduce this one as well, closing.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants