Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Migrate to GitHub Actions for CI #823

Closed
chrissantamaria opened this issue Jun 28, 2021 · 4 comments
Closed

Migrate to GitHub Actions for CI #823

chrissantamaria opened this issue Jun 28, 2021 · 4 comments

Comments

@chrissantamaria
Copy link
Contributor

Following up on conversation in #820 - Travis CI currently isn't running on new commits, looks like migrating to GitHub Actions might be worthwhile.

Opening an issue for easier tracking, will try to work on this in the next few days

@mweststrate
Copy link
Collaborator

Done, should be fixed now!

@chrissantamaria
Copy link
Contributor Author

@mweststrate sorry for the delay! Had to go out of town for the weekend, was going to take a look at this today but looks like you beat me to it 😅

Just rebased #820 and it still looks like tests aren't running, just the Netlify deploy. Maybe just needs a new PR / commit?

Also interestingly, it looks like the release job tried to run on my fork after updating from upstream. It failed since I don't have semantic-release correctly configured - I wonder if there's way to disable that job on forks? https://github.com/chrissantamaria/immer/runs/2992235778

@mweststrate
Copy link
Collaborator

Just rebased #820 and it still looks like tests aren't running, just the Netlify deploy. Maybe just needs a new PR / commit?

That is because Github doesn't run github actions automatically anymore for first-time contributors to a repo, so a maintainer has to kick it off manually for the first time. (Thank you bitcoin miners :-/)

Also interestingly, it looks like the release job tried to run on my fork after updating from upstream. It failed since I don't have semantic-release correctly configured - I wonder if there's way to disable that job on forks? https://github.com/chrissantamaria/immer/runs/2992235778

I added a check, probably won't work the first time, lol :-P

@chrissantamaria
Copy link
Contributor Author

It actually did work 😄 thanks for the fix!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants