Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow to disable resolver #3096

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow to disable resolver #3096

wants to merge 2 commits into from

Conversation

bertho-zero
Copy link

Fix #3095

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (67cc798) to head (bed542b).

Files with missing lines Patch % Lines
utils/resolve.js 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
+ Coverage   81.99%   91.85%   +9.86%     
==========================================
  Files          94       83      -11     
  Lines        4154     3573     -581     
  Branches     1395     1249     -146     
==========================================
- Hits         3406     3282     -124     
+ Misses        748      291     -457

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ljharb
ljharb requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable - although I think undefined is a better choice - and it will need tests.

@ljharb ljharb added semver-minor package: utils eslint-module-utils package labels Nov 6, 2024
@ljharb ljharb marked this pull request as draft November 6, 2024 19:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
package: utils eslint-module-utils package semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to disable default resolver
2 participants
@bertho-zero @ljharb