From c7ed0eec8d267e68bc769754279a670c9e0b6d6b Mon Sep 17 00:00:00 2001 From: Eli Ribble Date: Fri, 10 Jan 2025 16:36:26 -0800 Subject: [PATCH] Add logging messages when resolving domain name This can help people, like me, who don't realize that CNAME records will cause the plugin to attempt the DNS challenge on another top-level domain if their records are configured to do that. Resolves Iusse #100 --- certbot_dns_porkbun/cert/client.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/certbot_dns_porkbun/cert/client.py b/certbot_dns_porkbun/cert/client.py index 21687d4..0f6f686 100644 --- a/certbot_dns_porkbun/cert/client.py +++ b/certbot_dns_porkbun/cert/client.py @@ -105,6 +105,7 @@ def _perform(self, domain: str, validation_name: str, validation: str) -> None: try: # follow all CNAME and DNAME records canonical_name = resolver.canonical_name(domain) + logging.info("Resolved domain '%s' to '%s' via CNAME/DNAME record", domain, canonical_name) except (resolver.NoAnswer, resolver.NXDOMAIN): canonical_name = domain @@ -112,6 +113,7 @@ def _perform(self, domain: str, validation_name: str, validation: str) -> None: root_domain = f"{extract_result.domain}.{extract_result.suffix}" name = extract_result.subdomain + logging.info("Creating DNS challenge response record for %s", root_domain) try: self._validation_to_record[validation] = ( client.create_dns_record(