Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add keyboard interaction to close popover #501

Closed
mavarius opened this issue May 5, 2020 · 0 comments · Fixed by #502
Closed

Add keyboard interaction to close popover #501

mavarius opened this issue May 5, 2020 · 0 comments · Fixed by #502
Labels
enhancement Making it better all the time

Comments

@mavarius
Copy link
Collaborator

mavarius commented May 5, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
When a popover is opened, currently the only way to exit is by clicking outside of the element via mouse interaction. This is an accessibility issue and also leads to bugs.

Describe the solution you'd like
AS a user with a popover open
WHEN I press the ESC key
THEN the popover should close

Additional context
Eg: An interaction inside the popover opens a dialog but the popover persists.
image
@mavarius mavarius added the enhancement Making it better all the time label May 5, 2020
@alexpaxton alexpaxton mentioned this issue May 5, 2020
Merged
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
enhancement Making it better all the time
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow popovers to be closed via the Escape key influxdata/clockface
1 participant
@mavarius