From d57e4783082625b980f7757f73446f3172b0d6cd Mon Sep 17 00:00:00 2001 From: Beth Legesse Date: Wed, 18 May 2022 16:27:45 -0500 Subject: [PATCH 1/7] add an optional prop to TreeNavSubMenu --- src/Components/TreeNav/TreeNavSubMenu.tsx | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/Components/TreeNav/TreeNavSubMenu.tsx b/src/Components/TreeNav/TreeNavSubMenu.tsx index 217b6814..b5a75daa 100644 --- a/src/Components/TreeNav/TreeNavSubMenu.tsx +++ b/src/Components/TreeNav/TreeNavSubMenu.tsx @@ -10,18 +10,25 @@ import { } from '../../Types' import {Popover} from '../Popover' -export type TreeNavSubMenuProps = StandardFunctionProps +export interface HelpBarProp { + helpBar?: boolean +} + +export type TreeNavSubMenuProps = StandardFunctionProps & HelpBarProp export type TreeNavSubMenuRef = HTMLDivElement export const TreeNavSubMenu = forwardRef< TreeNavSubMenuRef, TreeNavSubMenuProps ->(({id, style, testID = 'tree-nav--sub-menu', className, children}, ref) => { +>(({id, style, testID = 'tree-nav--sub-menu', className, children, helpBar}, ref) => { const navMenuHeaderClass = classnames('cf-tree-nav--sub-menu', { [`${className}`]: className, }) - + let popoverPosition = PopoverPosition.ToTheRightTop + if (helpBar) { + popoverPosition = PopoverPosition.ToTheRight + } const triggerRef = useRef(null) return ( @@ -39,7 +46,7 @@ export const TreeNavSubMenu = forwardRef< hideEvent={PopoverInteraction.Hover} showEvent={PopoverInteraction.Hover} triggerRef={triggerRef} - position={PopoverPosition.ToTheRightTop} + position={popoverPosition} className="cf-popover__nav" distanceFromTrigger={4} /> From 6355eef7da0515ebe2b7047b24ceb31d0ebd6453 Mon Sep 17 00:00:00 2001 From: Beth Legesse Date: Wed, 18 May 2022 16:34:11 -0500 Subject: [PATCH 2/7] prettier --- src/Components/TreeNav/TreeNavSubMenu.tsx | 85 ++++++++++++----------- 1 file changed, 45 insertions(+), 40 deletions(-) diff --git a/src/Components/TreeNav/TreeNavSubMenu.tsx b/src/Components/TreeNav/TreeNavSubMenu.tsx index b5a75daa..64ef8eae 100644 --- a/src/Components/TreeNav/TreeNavSubMenu.tsx +++ b/src/Components/TreeNav/TreeNavSubMenu.tsx @@ -21,47 +21,52 @@ export type TreeNavSubMenuRef = HTMLDivElement export const TreeNavSubMenu = forwardRef< TreeNavSubMenuRef, TreeNavSubMenuProps ->(({id, style, testID = 'tree-nav--sub-menu', className, children, helpBar}, ref) => { - const navMenuHeaderClass = classnames('cf-tree-nav--sub-menu', { - [`${className}`]: className, - }) - let popoverPosition = PopoverPosition.ToTheRightTop - if (helpBar) { - popoverPosition = PopoverPosition.ToTheRight - } - const triggerRef = useRef(null) +>( + ( + {id, style, testID = 'tree-nav--sub-menu', className, children, helpBar}, + ref + ) => { + const navMenuHeaderClass = classnames('cf-tree-nav--sub-menu', { + [`${className}`]: className, + }) + let popoverPosition = PopoverPosition.ToTheRightTop + if (helpBar) { + popoverPosition = PopoverPosition.ToTheRight + } + const triggerRef = useRef(null) - return ( - <> -