Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add additional commit message type "deps" to categorize dependency updates #17

Closed
sspaink opened this issue Jun 13, 2022 · 3 comments
Closed

Comments

@sspaink
Copy link
Contributor

sspaink commented Jun 13, 2022

The Telegraf project has a lot of dependencies, therefore we get a lot of pull requests that update the dependencies (such as this one influxdata/telegraf#11266) and we are reporting these in the changelog in a separate section. I was hoping to find a way to categorize these types of pull requests so when we generate the changelog it gets sorted automatically.

@jacobmarble and @tysonkamp What do you think about extending the support "types" (e.g. feat,fix) to include something like "deps"? This definitely isn't a blocker, I think there are other approaches we can take, but curious to hear your thoughts on this possibility?

@tysonkamp
Copy link
Contributor

I'm fine with it, but I am no opinionated regarding commit messages. @jacobmarble I defer to you and other dev managers and dev teams. Thoughts?

@domodwyer
Copy link
Contributor

For what it's worth, dependabot opens PRs tagged as chore(deps) which might be worth using for consistency with the automated stuff 👍

@sspaink
Copy link
Contributor Author

sspaink commented Jun 16, 2022

I didn't know dependabot already had a convention with chore(deps), we can definitely work with that for automation. Thank you!

@sspaink sspaink closed this as completed Jun 16, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants