Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document Ruby 1.9 dependency #127

Closed
temujin9 opened this issue Apr 12, 2012 · 1 comment
Closed

Document Ruby 1.9 dependency #127

temujin9 opened this issue Apr 12, 2012 · 1 comment
Milestone

Comments

@temujin9
Copy link
Contributor

Nobody at Infochimps uses 1.8 internally, and we lack a full test framework to ameliorate that. Therefore, we don't officially support Ruby 1.8, although we will happily accept pull requests aimed at keeping Ironfan working there as well.

Not 100% sure where this should end up; probably in the README. @mrflip, please chime in if you have other suggestions.

@mrflip
Copy link
Member

mrflip commented Apr 16, 2012

Updated the READMEs; closing.

To anyone who wants to port:

  • define_method in ironfan-pantry/cookbooks/silverware: 1.9 allows default and block parameters to a block. You'll have to change this to the string form of class_eval, calling def.
  • realdirpath in the knife.rb
  • I don't think there are occurrences of new-style hashes, BasicObject, or any assumptions that a hash is ordered.

@mrflip mrflip closed this as completed Apr 16, 2012
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants