Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Test ICS29 with additional chains #3091

Closed
5 tasks
Tracked by #3169
ljoss17 opened this issue Feb 16, 2023 · 2 comments · Fixed by #4066
Closed
5 tasks
Tracked by #3169

Test ICS29 with additional chains #3091

ljoss17 opened this issue Feb 16, 2023 · 2 comments · Fixed by #4066
Assignees
@ljoss17
Labels
A: blocked Admin: blocked by another (internal/external) issue or PR I: CI/CD Internal: related to CI/CD pipeline O: ics29-fee Objective: Fee middleware support O: tests Objective: Test more aspect of the relayer
Milestone
v1.11

Comments

@ljoss17
Copy link
Contributor

ljoss17 commented Feb 16, 2023 •
edited
Loading

Summary

As more chains will enable the ICS29 module, running Hermes integration tests for ICS29 with additional chains will help prepare when this will be used in production.

Problem Definition

At the moment Hermes runs the integration tests only with simd v5 and simd v6.

Proposal

Investigate if additional chains have enabled ICS29 module. Update Cosmos Nix if required and integrate the chains in the ICS29 integration test if it is the case.

Chains fee integration issues

Tracking issues

Acceptance Criteria

Running Hermes ICS29 integration tests with chains such as Osmosis, Stride, Gaia, ...

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ljoss17 ljoss17 added O: tests Objective: Test more aspect of the relayer I: CI/CD Internal: related to CI/CD pipeline O: ics29-fee Objective: Fee middleware support labels Feb 16, 2023
@ljoss17 ljoss17 self-assigned this Feb 16, 2023
@ljoss17
Copy link
Contributor Author

ljoss17 commented Feb 16, 2023

Current status:

  • Gaia: will maybe enable the module for v10
  • Osmosis: will wait for channel upgradability
  • Stride: probably in an upcoming upgrade. Not the following one, but the one after (currently at v5.1.1

@seanchen1991 seanchen1991 mentioned this issue Feb 21, 2023
Closed
9 tasks
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Feb 21, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 🛑 Blocked in Hermes Feb 21, 2023
@seanchen1991 seanchen1991 added the A: blocked Admin: blocked by another (internal/external) issue or PR label Feb 21, 2023
@romac romac modified the milestone: v1.4 Mar 14, 2023
@seanchen1991 seanchen1991 mentioned this issue Mar 15, 2023
Open
3 tasks
@seanchen1991 seanchen1991 added this to the v1.6 milestone Apr 19, 2023
@ljoss17
Copy link
Contributor Author

ljoss17 commented May 11, 2023

White Whale v2.0.2 have the module enabled:

@seanchen1991 seanchen1991 mentioned this issue Jun 27, 2023
Closed
@seanchen1991 seanchen1991 modified the milestones: v1.6, v1.7 Jul 7, 2023
@romac romac modified the milestones: v1.7, v1.8 Aug 31, 2023
@romac romac modified the milestones: v1.8, v1.9 Jan 16, 2024
@romac romac modified the milestones: v1.9, v1.10 Apr 2, 2024
@ljoss17 ljoss17 mentioned this issue Jun 25, 2024
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 🛑 Blocked to ✅ Done in Hermes Jun 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@ljoss17 ljoss17

Labels
A: blocked Admin: blocked by another (internal/external) issue or PR I: CI/CD Internal: related to CI/CD pipeline O: ics29-fee Objective: Fee middleware support O: tests Objective: Test more aspect of the relayer
Projects
Hermes
Status: ✅ Done
Milestone
v1.11
Development

Successfully merging a pull request may close this issue.

Test ICS29 fees with additional chains informalsystems/hermes
3 participants
@romac @seanchen1991 @ljoss17