Skip to content

check-substrate job fails due to displaydoc issue with the latest Rust nightly compiler #1105

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
Farhad-Shabani opened this issue Feb 28, 2024 · 2 comments · Fixed by #1264
Closed

check-substrate job fails due to displaydoc issue with the latest Rust nightly compiler #1105

Farhad-Shabani opened this issue Feb 28, 2024 · 2 comments · Fixed by #1264
Assignees
@rnbguy
Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews S: CI/CD Scope: related to CI/CD S: no-std Scope: support no_std envs

Comments

@Farhad-Shabani
Copy link
Member

Farhad-Shabani commented Feb 28, 2024 •
edited
Loading

Summary

Context: #1099 (comment)

The check-substrate job for no_std check relies on nightly channel, which fails when running with latest nightly > 2024-02-27 compiler that accepted rust-lang/rust#120393. This should be resolved in yaahc/displaydoc#46.

As a temporary solution, we've set the NIGHTLY_VERSION to nightly-2024-02-24. It's worthwhile to explore whether it's essential to perform the no_std checks on the nightly channel.
@Farhad-Shabani Farhad-Shabani added S: no-std Scope: support no_std envs S: CI/CD Scope: related to CI/CD A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews labels Feb 28, 2024
@github-project-automation github-project-automation bot moved this to 📥 To Do in ibc-rs Feb 28, 2024
@Manishearth
Copy link

Displaydoc 0.2.5 was published (yaahc/displaydoc#51) which should fix this error.

@rnbguy rnbguy mentioned this issue Jun 21, 2024
Merged
7 tasks
@rnbguy rnbguy self-assigned this Jun 21, 2024
@rnbguy
Copy link
Member

rnbguy commented Jun 21, 2024

Awesome ! Works on latest nightlies ✨

@github-project-automation github-project-automation bot moved this from 📥 To Do to ✅ Done in ibc-rs Jun 21, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rnbguy rnbguy

Labels
A: low-priority Admin: low priority / non urgent issue, expect longer wait time for PR reviews S: CI/CD Scope: related to CI/CD S: no-std Scope: support no_std envs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): update project dependencies informalsystems/ibc-rs
3 participants
@Manishearth @rnbguy @Farhad-Shabani